[PRMP-631] Bulk Upload E2e Tests #975
Conversation
|
| if self.workspace in {"pre-prod", "ndr-test"} | ||
| else f"api-{self.workspace}.{domain}" | ||
| f"api.{self.workspace}.{domain}" if self.workspace in {"pre-prod", | ||
| "ndr-test"} else f"api-{self.workspace}.{domain}" |
There was a problem hiding this comment.
Looks a bit weird. If you commit in the dev container then it should run the pre-commits etc.
|
|
||
|
|
||
| class DataHelper: | ||
| class PatientRecordDataHelper: |
There was a problem hiding this comment.
Why do we need to change this class name?
| ) | ||
| return self.dynamo_service.get_item(table_name=self.dynamo_table, key={"ID": record["id"]}) | ||
|
|
||
| def scan_lloyd_george_table(self): |
There was a problem hiding this comment.
Unless I'm missing something, all of these new methods are only relevant to the Lloyd George tests. So why not put them in the extended LloydGeorgeDataHelper class?
| assert ( | ||
| f"https://{APIM_ENDPOINT}/national-document-repository/FHIR/R4/DocumentReference/{LLOYD_GEORGE_SNOMED}~" | ||
| in attachment_url | ||
| f"https://{APIM_ENDPOINT}/national-document-repository/FHIR/R4/DocumentReference/{LLOYD_GEORGE_SNOMED}~" |
There was a problem hiding this comment.
Spacing feels wrong compared to main python code are tests different are they supposed to be spaced like this?
| fetch_with_retry, | ||
| ) | ||
| from tests.e2e.helpers.data_helper import LloydGeorgeDataHelper | ||
| from tests.e2e.helpers.patient_record_data_helper import LloydGeorgeDataHelper |
There was a problem hiding this comment.
wonder if its worth renaming class to from LloydGeorgeDataHelper to something better also? might be to big for this ticket?
|
Seems to be a lot of formatting going on here. Are you sure you're running pre-commits through the dev container? |
|
|
||
| def fetch_with_retry_mtls( | ||
| session, url, headers, condition_func=None, max_retries=5, delay=10 | ||
| session, url, headers, condition_func=None, max_retries=5, delay=10 |
There was a problem hiding this comment.
Formatting doesn't seem right
3 participants
Overview
Jira ticket: TBC
Description
Context
Checklist
Tasks for all changes:
I have run git pre-commits.(WIP)Deploy - Sandbox- workflow run - TBCSANDBOX Full- Deploy feature branch to sandbox- workflow run - TBCAdditional tasks for UI changes (delete if not applicable):
SANDBOX - UI Smoke Test- workflow run - TBC