[PRMP-1162] Href navigate changed to onclick navigate#998
Merged
adamwhitingnhs merged 3 commits intomainfrom Jan 19, 2026
Merged
[PRMP-1162] Href navigate changed to onclick navigate#998adamwhitingnhs merged 3 commits intomainfrom
adamwhitingnhs merged 3 commits intomainfrom
Conversation
adamwhitingnhs
force-pushed
the
PRMP-1162
branch
from
5b84995 to
a03d009
Compare
lillie-dae
previously approved these changes
Jan 19, 2026
adamwhitingnhs
force-pushed
the
PRMP-1162
branch
from
a03d009 to
651da39
Compare
kamenbachvarov-nhs
previously approved these changes
Jan 19, 2026
kamenbachvarov-nhs
previously approved these changes
Jan 19, 2026
lillie-dae
previously approved these changes
Jan 19, 2026
adamwhitingnhs
dismissed stale reviews from lillie-dae and kamenbachvarov-nhs
via
63babb2
Code security issues foundView full details here. |
adamwhitingnhs
force-pushed
the
PRMP-1162
branch
from
63babb2 to
471ef79
Compare
Code security issues foundView full details here. |
Code security issues foundView full details here. |
kamenbachvarov-nhs
approved these changes
Jan 19, 2026
lillie-dae
approved these changes
Jan 19, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
https://nhsd-jira.digital.nhs.uk/browse/PRMP-1162
Description
Replace all internal href links with on click react navigate calls.
Context
We appear to still be having some caching issues in prod, it looks like when we do a route navigation using a href link instead of a react router navigate, the browser treats this is a page reload but fetches a cached version of the webpage instead of nginx returning the correct index html file.
This PR changes all the internal href links to use react router navigate.
Checklist
Tasks for all changes:
I have run git pre-commits.(WIP)Deploy - Sandbox- workflow run - TBCSANDBOX Full- Deploy feature branch to sandbox- workflow run - TBC