Skip to content

CI: fix crashes when brakeman parsing fails #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bshand merged 1 commit into from
Apr 29, 2022
Merged

CI: fix crashes when brakeman parsing fails #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## [Unreleased]
* No unreleased changes
### Fixed
* CI: fix crashes when brakeman parsing fails

## 6.1.0 / 2022-04-28
### Fixed
Expand Down
19 changes: 18 additions & 1 deletion lib/tasks/ci/brakeman.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,24 @@ namespace :ci do

brakeman = NdrDevSupport::RakeCI::BrakemanHelper.new
brakeman.commit = @commit
brakeman.run(strict: true)
begin
brakeman.run(strict: true)
rescue StandardError => e
warn <<~MESSAGE
Error: Brakeman failed with #{e.class}: #{e}
There is probably a ruby syntax error in one of the files. To find it, run:
$ brakeman -I --debug
For the full backtrace, run
$ rake ci:brakeman --trace
MESSAGE
@attachments << {
color: 'danger',
title: 'Brakeman Error',
text: 'Brakeman run failed. Run brakeman -I --debug',
footer: 'bundle exec rake ci:brakeman:strict'
}
next
end

@metrics.concat(brakeman.metrics)
@attachments.concat(brakeman.attachments)
Expand Down