Skip to content

# Change default browser for integration tests to headless Chrome #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bshand merged 1 commit into from
Oct 5, 2022
Merged

# Change default browser for integration tests to headless Chrome #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## [Unreleased]
## [Unreleased]
* No unreleased changes
## Changed
* Change default browser for integration tests to headless Chrome
* Drop support for Poltergeist and PhantomJS

## 6.1.9 / 2022-10-04
### Fixed
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ $ find . -iregex .*\.rake$ | xargs rake rubocop:diff:file

ndr_dev_support bundles a configured Rails integration testing environment.

By default, it uses `capybara` and `poltergeist` to drive a PhantomJS headless browser, and includes some sensible configuration.
By default, it uses `capybara` and `selenium` to drive a headless Chrome browser, and includes some sensible configuration.

To use, simply add the following to your application's `test_helper.rb`

Expand Down
4 changes: 0 additions & 4 deletions code_safety.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,6 @@ file safety:
comments:
reviewed_by: josh.pencheon
safe_revision: f1a32b1f2d1851b87a883dbf8620aa0e921e436c
lib/ndr_dev_support/integration_testing/drivers/poltergeist.rb:
comments:
reviewed_by: josh.pencheon
safe_revision: f1a32b1f2d1851b87a883dbf8620aa0e921e436c
lib/ndr_dev_support/integration_testing/drivers/switchable.rb:
comments:
reviewed_by: josh.pencheon
Expand Down
1 change: 0 additions & 1 deletion lib/ndr_dev_support/integration_testing.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
require 'ndr_dev_support/integration_testing/drivers/chrome'
require 'ndr_dev_support/integration_testing/drivers/chrome_headless'
require 'ndr_dev_support/integration_testing/drivers/firefox'
require 'ndr_dev_support/integration_testing/drivers/poltergeist'
require 'ndr_dev_support/integration_testing/drivers/switchable'

Capybara.default_driver = :switchable
Expand Down
18 changes: 0 additions & 18 deletions lib/ndr_dev_support/integration_testing/drivers/poltergeist.rb
View file
Open in desktop

This file was deleted.

9 changes: 1 addition & 8 deletions lib/ndr_dev_support/integration_testing/drivers/switchable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,8 @@ module Drivers
# A meta-driver that allows the driver to be set using the `INTEGRATION_DRIVER`
# environment variable (e.g. for a CI matrix), assuming that driver has been pre-registered
# with Capybara.

# Although the aim is to move to Chrome headless, we keep poltergeist as the default
# driver for now. For motivation behind not changing immediately, see the "Differences
# between Poltergeist and Selenium" section of:
#
# https://about.gitlab.com/2017/12/19/moving-to-headless-chrome/
#
module Switchable
DEFAULT = :poltergeist
DEFAULT = :chrome_headless
CONFIGURED = ENV.fetch('INTEGRATION_DRIVER', DEFAULT).to_sym

Capybara.register_driver(:switchable) do |app|
Expand Down
3 changes: 1 addition & 2 deletions ndr_dev_support.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,8 @@ Gem::Specification.new do |spec|
spec.add_dependency 'capybara', '>= 3.34'
spec.add_dependency 'capybara-screenshot'
spec.add_dependency 'minitest', '~> 5.11'
spec.add_dependency 'poltergeist', '>= 1.8.0'
spec.add_dependency 'selenium-webdriver'
spec.add_dependency 'show_me_the_cookies', '< 6.0' # Newer versions drop Poltergeist support
spec.add_dependency 'show_me_the_cookies'
spec.add_dependency 'webdrivers', '>= 3.9'

# CI server dependencies:
Expand Down