Merged
Conversation
joshpencheon
force-pushed
the
flakey_tests
branch
from
5a205d4 to
4f0272d
Compare
Minitest appears to follow semantic versioning; pins to the 5.x release series.
Contributor
Author
|
I can't think of a good way to add independent test coverage of this, without having a separate test suite which the main test suite could run, and capture output from. The issue of keeping the tests separate stems from how minitest's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
flakey_testmethod to minitest's DSL. Positioning as a pragmatic necessary evil, given CI pipelines are being affected.If a test declared as "flakey" fails, but then passes after retries, it will be reported as a Pass. However, the CI will additional report it as being flakey (in a purple bubble to Slack).