Skip to content

Allow magic commit message part to cause build to be skipped#65

Closed
joshpencheon wants to merge 1 commit intomasterfrom
ci_skipping
Closed

Allow magic commit message part to cause build to be skipped#65
joshpencheon wants to merge 1 commit intomasterfrom
ci_skipping

Conversation

@joshpencheon
Copy link
Contributor

Commits tagged with variants of [ci skip] will be skipped over.

@timgentry - I have a niggling feeling you didn't want this feature, so deferring to you.

cc: @miles-smith

Magic part not included in this message, for obvious reasons...
@joshpencheon joshpencheon requested a review from timgentry August 15, 2019 13:52
@timgentry
Copy link
Contributor

Sorry, but I don't want this feature as it stands. Analysis of who did what (test coverage, failures, smelly code, etc) will generally depend on every commit being tested, which is also the main reason why we wrote RakeCI, rather than using Jenkins or something else.

I would prefer that we are smarter about when we skip. For example, we could look for a .rakecignore file within the root of a project and ignore those files. This would allow us to skip precise files, eg. user lists or code_safety.yml.

@timgentry timgentry closed this Aug 19, 2019
@timgentry
Copy link
Contributor

I've added my requirements as #66.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants