# Bumped rubocop and added rubocop-rails. Resolves #70.#72
Merged
joshpencheon merged 1 commit intoNHSDigital:masterfrom Jan 23, 2020
Merged
# Bumped rubocop and added rubocop-rails. Resolves #70.#72joshpencheon merged 1 commit intoNHSDigital:masterfrom
joshpencheon merged 1 commit intoNHSDigital:masterfrom
Conversation
Contributor
|
Looking at the output differences of these rubocop versions against one of our projects, I can't see anything jumping out that we'd want to tweak, so no objection to merging this. We had previously agreed to follow the default style guide more closely, and just "go with the flow", anyway... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.