Skip to content

# allow RuboCop config to be bundled, and required by host projects. #71#74

Merged
timgentry merged 2 commits intomasterfrom
rubocop_extension
Jan 27, 2020
Merged

# allow RuboCop config to be bundled, and required by host projects. #71#74
timgentry merged 2 commits intomasterfrom
rubocop_extension

Conversation

@joshpencheon
Copy link
Contributor

@joshpencheon joshpencheon commented Jan 24, 2020

@timgentry I've taken a stab at this.

  • Configuration is now defined in config/rubocop/ndr.yml
  • Usage is require: ndr_dev_support

Two hurdles were:

  • recursive loading (allowing ndr_dev_support to load rubocop-rails)
  • dogfooding (allowing ndr_dev_support's .rubocop.yml to use our config)

Things seem to work ok now.

@joshpencheon
Copy link
Contributor Author

The outcome of rubocop/rubocop-extension-generator/pull/9 may be informative in terms of whether this is a good approach!

@timgentry
Copy link
Contributor

Great solution, thanks @joshpencheon

@timgentry timgentry merged commit 61609a3 into master Jan 27, 2020
@timgentry timgentry deleted the rubocop_extension branch January 27, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants