Add 'test_repeatedly', for help with flakey tests#85
Merged
joshpencheon merged 2 commits intomasterfrom Jan 28, 2021
Merged
Conversation
ollietulloch
approved these changes
Jan 28, 2021
Contributor
ollietulloch
left a comment
There was a problem hiding this comment.
Thanks @joshpencheon - I've pointed an app at this branch locally and oberved an integration test running repeatedly for a given number of times, or 100 times if not specified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Summary
Often, when investigating whether a test is flakey, it's helpful to be able to run a test multiple times. This tends to get done by either using a bash loop (which can be slow) or hacking about in the test file (which can get messy).
Using a bash loop to repeatedly instantiate a runner is slow:
And mucking around duplicating the test gets messy:
This PR
This PR adds the
test_repeatedlyconstruct, to make the latter pattern (which executes more efficiently) quick and simple to do, whilst retaining some configurability.