Capybara: use animation-disabling middleware#87
Merged
joshpencheon merged 1 commit intomasterfrom Jan 12, 2021
Merged
Conversation
This will inject something into the head of all test-env responses to neuter all jQuery animations, and CSS animations/transitions.
Contributor
Author
|
Testing this with a host project, in an integration test we see: CSS rules being injected: /* puts Nokogiri::HTML(page.body).xpath('//head/style').text */
*, *::before, *::after {
transition: none !important;
animation-duration: 0s !important;
animation-delay: 0s !important;
scroll-behavior: auto !important;
}And JS: /* puts Nokogiri::HTML(page.body).xpath('//head/script').text */
(typeof jQuery !== 'undefined') && (jQuery.fx.off = true); |
ollietulloch
approved these changes
Jan 12, 2021
Contributor
There was a problem hiding this comment.
Thanks @joshpencheon, looks good to me.
I've run this against a host app and tests are passing. I have also observed the below being injected:
*, *::before, *::after {
transition: none !important;
animation-duration: 0s !important;
animation-delay: 0s !important;
scroll-behavior: auto !important;
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recent versions of Capybara can automatically inject an additional middleware in the test environment, that appends animation-disabling statements to the end of the
<head>. This will neuter all jQuery animations, and CSS animations/transitions.This PR enables this middleware by default, and bumps the capybara requirement to the latest release, to get the most animation-disabling potential.