Conversation
allows us to fetch lazily/interactively for large repositories
This commit knowingly disables interactive mode temporarily
Sorting by last_changed_revision isn't a helpful order to review in - an unreviewed file with lots of churn would appear as a low priority, for example. See original discussion on #7
Allows code review to be partitioned between multiple members of staff up front
bshand
approved these changes
Jan 28, 2021
Contributor
bshand
left a comment
bshand
left a comment
There was a problem hiding this comment.
This looks good to me, and I've tested it successfully on my local git working copy.
ollietulloch
approved these changes
Jan 28, 2021
Contributor
ollietulloch
left a comment
ollietulloch
left a comment
There was a problem hiding this comment.
Thanks @joshpencheon - looks good. Succesfully produced an outfile.
The filter logic is neat, it'll make chunking up code review much easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a refactoring and feature enhancement of the
audit:codecode. It:I've kept this as one big PR, rather than numerous smaller ones, as the end goal was to be able to partition large amount of code review and allocate it out in an out-of-band process, and all the changes here are needed for that.
One way of giving this a go is to check the branch out, and try to dogfood and do the outstanding review on
ndr_dev_support!