Code linting: don't fail when there are no linkable changes#97
Merged
joshpencheon merged 3 commits intomasterfrom Feb 18, 2021
Merged
Code linting: don't fail when there are no linkable changes#97joshpencheon merged 3 commits intomasterfrom
joshpencheon merged 3 commits intomasterfrom
Conversation
A non-zero exit status means that downstream processes assume failure. In reality, we want to to fail only when there are lint issues. If a user has interactively run against a malformed range, they still receive a message to warn them that no changes were found to analyse.
joshpencheon
commented
Feb 17, 2021
ollietulloch
approved these changes
Feb 18, 2021
Contributor
ollietulloch
left a comment
ollietulloch
left a comment
There was a problem hiding this comment.
Thanks @joshpencheon - looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A non-zero exit status means that downstream processes assume failure. In reality, we want to to fail only when there are lint issues.
This PR ensures that the exit status is zero unless linting issues are actually found. If a user has interactively run against a malformed range, they still receive a message to warn them that no changes were found to analyse.