Feature/Replace ODS ORD API with ODS FIHR R4 API - jira ndrs2 2282#13
Merged
Feature/Replace ODS ORD API with ODS FIHR R4 API - jira ndrs2 2282#13
Conversation
Rails.logger is not available in test env, so instead create a new Logger and print straight to the console. This displays in the test console and also stops the test crashing from the lack of Rails.
Tests that find works properly when it gets a good response and returns the right org. Also tests that when the org doesn't exist it returns nil instead of crashing.
…rored. JIRA 2282.
Changed Base to inherit from ActiveResource::Base and then Organisation and Client still have access to ActiveResource::Base via Base. This should give the best of both worlds and fix the duplication issues in Base and Organisation (and the inheritance issues)
Add Organisation Sync using the search function.
kenny-lee-1
reviewed
Aug 4, 2025
kenny-lee-1
reviewed
Aug 4, 2025
kenny-lee-1
reviewed
Aug 12, 2025
kenny-lee-1
reviewed
Aug 12, 2025
kenny-lee-1
reviewed
Aug 12, 2025
PR Feedback
These overrides were needed before inheriting from ActiveResource::Base but are now redundant with proper inheritance.
…2282. - Explain endpoint method wrapper for test stubbing - Document Organisation/Organization naming used in NHS API paths PR Feedback.
Removed a little prematurely.
kenny-lee-1
approved these changes
Aug 22, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing a lot of the old ODS code with ODT frame work to make this more generic. Updating the tests and generally getting this ready to replace the ODS API.