Fix bad URI error from trailing whitespace in FHIR organization lookups.#22
Merged
Fix bad URI error from trailing whitespace in FHIR organization lookups.#22
Conversation
Contributor
Rikki-Dev
commented
Mar 5, 2026
Rikki-Dev
commented
- Strip whitespace from IDs in Base.find before URL construction
- Add rescue for ApiError/InvalidURIError in Organisation.find for graceful degradation of any future URI issues
- Strip whitespace from IDs in Base.find before URL construction - Add rescue for ApiError/InvalidURIError in Organisation.find for graceful degradation of any future URI issues
kenny-lee-1
approved these changes
Mar 9, 2026
Contributor
kenny-lee-1
left a comment
kenny-lee-1
left a comment
There was a problem hiding this comment.
I think we should possibly investigate catching all/any NdrLookup Errors on the era side
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.