Skip to content

CCM-14199 - Foundational: Infrastructure as Code and Core Types#31

Merged
mjewildnhs merged 24 commits intomainfrom
feature/CCM-14199-foundation
Feb 27, 2026
Merged

CCM-14199 - Foundational: Infrastructure as Code and Core Types#31
mjewildnhs merged 24 commits intomainfrom
feature/CCM-14199-foundation

Conversation

@mjewildnhs
Copy link
Contributor

@mjewildnhs mjewildnhs commented Feb 10, 2026

Description

This PR establishes the foundational infrastructure and core type definitions for the NHS Notify Client Callbacks system. It includes:

  • Terraform Infrastructure: S3 bucket for client configuration storage
  • TypeScript Type System: Comprehensive type definitions for status events, callback payloads, and client configuration
  • Development Tooling: Updated ESLint configuration, Jest setup, Sonar scanner properties, and pre-commit hooks

Context

This work is part of CCM-14199 and lays the groundwork for externalizing client callbacks from the main Communications Manager system. The foundational infrastructure enables:

  1. Receiving status transition events from the internal EventBus
  2. Transforming and filtering events based on client-specific subscriptions
  3. Delivering callbacks to client webhooks with appropriate rate limiting

This foundation will be built upon in subsequent phases to add full transformation logic, error handling, DLQs, and monitoring.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@mjewildnhs mjewildnhs force-pushed the feature/CCM-14199-foundation branch from 80e7546 to fd5a645 Compare February 10, 2026 16:13
@mjewildnhs mjewildnhs force-pushed the feature/CCM-14199-foundation branch 4 times, most recently from 5fdffbf to 2165b0e Compare February 11, 2026 14:58
@sonarqubecloud
Copy link

@mjewildnhs mjewildnhs force-pushed the feature/CCM-14199-foundation branch from d97e7b1 to a965084 Compare February 12, 2026 09:49
@mjewildnhs mjewildnhs force-pushed the feature/CCM-14199-foundation branch from 5e03c91 to 7ca4971 Compare February 13, 2026 16:02
@mjewildnhs mjewildnhs marked this pull request as ready for review February 18, 2026 14:50
@mjewildnhs mjewildnhs requested review from a team as code owners February 18, 2026 14:50
rhyscoxnhs
rhyscoxnhs previously approved these changes Feb 19, 2026
Copy link

@rhyscoxnhs rhyscoxnhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sidnhs
sidnhs previously approved these changes Feb 26, 2026
Copy link

@cgitim cgitim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REFCOM changes :(

rhyscoxnhs
rhyscoxnhs previously approved these changes Feb 26, 2026
@mjewildnhs mjewildnhs dismissed stale reviews from rhyscoxnhs and sidnhs via 9faa10e February 26, 2026 15:59
@mjewildnhs mjewildnhs requested a review from cgitim February 26, 2026 16:01
@mjewildnhs mjewildnhs requested a review from sidnhs February 27, 2026 09:17
@mjewildnhs mjewildnhs force-pushed the feature/CCM-14199-foundation branch from 0f6e0ea to 5549615 Compare February 27, 2026 09:30
@mjewildnhs mjewildnhs force-pushed the feature/CCM-14199-foundation branch from 5549615 to 6e38075 Compare February 27, 2026 09:30
@mjewildnhs mjewildnhs merged commit b9c5006 into main Feb 27, 2026
34 checks passed
@mjewildnhs mjewildnhs deleted the feature/CCM-14199-foundation branch February 27, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants