Skip to content

CCM-14202 - Backward-Compatible Event Processing#54

Merged
cgitim merged 7 commits intomainfrom
feature/CCM-14202
Mar 17, 2026
Merged

CCM-14202 - Backward-Compatible Event Processing#54
cgitim merged 7 commits intomainfrom
feature/CCM-14202

Conversation

@rhyscoxnhs
Copy link
Copy Markdown
Contributor

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@rhyscoxnhs rhyscoxnhs requested a review from a team as a code owner March 11, 2026 12:04
@rhyscoxnhs rhyscoxnhs force-pushed the feature/CCM-14202 branch 2 times, most recently from 13d292b to b4c76ca Compare March 11, 2026 12:07
@rhyscoxnhs rhyscoxnhs requested a review from Copilot March 11, 2026 12:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds focused unit test coverage for transforming core domain “status published” CloudEvents into backward-compatible client callback payloads in the client-transform-filter Lambda.

Changes:

  • Added transform pipeline tests validating MessageStatus/ChannelStatus attribute mapping (including failure fields), payload type, and message link.
  • Introduced reusable fixtures for message-status and channel-status core domain events plus expected attribute objects.
  • Added a small test utility to extract typed attributes from a callback payload.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
lambdas/client-transform-filter-lambda/src/tests/utils/payload-comparator.ts Adds helper functions to extract typed attributes from transformed callback payloads for assertions.
lambdas/client-transform-filter-lambda/src/tests/services/transform-pipeline.test.ts Adds end-to-end-ish transformer tests asserting transformed attributes, types, and links for both event kinds.
lambdas/client-transform-filter-lambda/src/tests/fixtures/core-domain-events/message-status-event.ts Adds message status CloudEvent fixtures and expected transformed attributes (including failure variant).
lambdas/client-transform-filter-lambda/src/tests/fixtures/core-domain-events/channel-status-event.ts Adds channel status CloudEvent fixtures and expected transformed attributes (including failure variant).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rhyscoxnhs rhyscoxnhs requested a review from a team as a code owner March 11, 2026 16:10
@rhyscoxnhs rhyscoxnhs requested a review from cgitim March 11, 2026 16:14
@cgitim cgitim force-pushed the feature/CCM-14202 branch from 4b9fc95 to 5de503a Compare March 17, 2026 15:45
@cgitim cgitim merged commit 89698b8 into main Mar 17, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants