CCM-14202 - Backward-Compatible Event Processing#54
Merged
Conversation
13d292b to
b4c76ca
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds focused unit test coverage for transforming core domain “status published” CloudEvents into backward-compatible client callback payloads in the client-transform-filter Lambda.
Changes:
- Added transform pipeline tests validating MessageStatus/ChannelStatus attribute mapping (including failure fields), payload type, and message link.
- Introduced reusable fixtures for message-status and channel-status core domain events plus expected attribute objects.
- Added a small test utility to extract typed attributes from a callback payload.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lambdas/client-transform-filter-lambda/src/tests/utils/payload-comparator.ts | Adds helper functions to extract typed attributes from transformed callback payloads for assertions. |
| lambdas/client-transform-filter-lambda/src/tests/services/transform-pipeline.test.ts | Adds end-to-end-ish transformer tests asserting transformed attributes, types, and links for both event kinds. |
| lambdas/client-transform-filter-lambda/src/tests/fixtures/core-domain-events/message-status-event.ts | Adds message status CloudEvent fixtures and expected transformed attributes (including failure variant). |
| lambdas/client-transform-filter-lambda/src/tests/fixtures/core-domain-events/channel-status-event.ts | Adds channel status CloudEvent fixtures and expected transformed attributes (including failure variant). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lambdas/client-transform-filter-lambda/src/__tests__/utils/payload-comparator.ts
Outdated
Show resolved
Hide resolved
cgitim
requested changes
Mar 11, 2026
...nt-transform-filter-lambda/src/__tests__/fixtures/core-domain-events/channel-status-event.ts
Show resolved
Hide resolved
...nt-transform-filter-lambda/src/__tests__/fixtures/core-domain-events/channel-status-event.ts
Show resolved
Hide resolved
...nt-transform-filter-lambda/src/__tests__/fixtures/core-domain-events/message-status-event.ts
Show resolved
Hide resolved
...nt-transform-filter-lambda/src/__tests__/fixtures/core-domain-events/message-status-event.ts
Show resolved
Hide resolved
...nt-transform-filter-lambda/src/__tests__/fixtures/core-domain-events/message-status-event.ts
Show resolved
Hide resolved
cgitim
approved these changes
Mar 12, 2026
sidnhs
approved these changes
Mar 12, 2026
mjewildnhs
reviewed
Mar 17, 2026
lambdas/client-transform-filter-lambda/src/services/transformers/message-status-transformer.ts
Show resolved
Hide resolved
lambdas/client-transform-filter-lambda/src/services/transformers/channel-status-transformer.ts
Show resolved
Hide resolved
lambdas/client-transform-filter-lambda/src/__tests__/utils/payload-comparator.ts
Outdated
Show resolved
Hide resolved
lambdas/client-transform-filter-lambda/src/__tests__/services/transform-pipeline.test.ts
Outdated
Show resolved
Hide resolved
mjewildnhs
approved these changes
Mar 17, 2026
4b9fc95 to
5de503a
Compare
cgitim
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.