Skip to content

CCM-16644: Update Digital Letters Reporting Rule Policy#126

Open
gareth-allan wants to merge 1 commit into
mainfrom
feature/CCM-16644_reporting_permissions
Open

CCM-16644: Update Digital Letters Reporting Rule Policy#126
gareth-allan wants to merge 1 commit into
mainfrom
feature/CCM-16644_reporting_permissions

Conversation

@gareth-allan
Copy link
Copy Markdown
Contributor

@gareth-allan gareth-allan commented May 1, 2026

Description

This PR updates the IAM policy used by the EventBridge rule that forwards Digital Letters events to the reporting domain, so that it uses the correct name for the KMS key created in this PR in the reporting repo.

Context

This is required because the name of the key actually created differs from the one predicted when we originally created this rule.

Validation

Deployed the changes from this branch, with the changes from this nhs-notify-internal PR to my gaal8 eventbus environment: https://github.com/NHSDigital/nhs-notify-internal/actions/runs/25679915060
Screenshot 2026-05-11 at 16 34 09

I also deployed the changes from this reporting PR to the dev main reporting environment:
Screenshot 2026-05-11 at 16 43 48

Sent an event matching the shape of a Digital Letters event to my gaal8 eventbus' data plane:
Screenshot 2026-05-11 at 16 35 24

Verified, using CloudWatch, that the event matched the rule and was successfully forwarded to the reporting repo:
Screenshot 2026-05-11 at 16 41 59

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@gareth-allan gareth-allan force-pushed the feature/CCM-16644_reporting_permissions branch 3 times, most recently from 3ee2155 to a8f5e96 Compare May 7, 2026 08:59
@gareth-allan gareth-allan force-pushed the feature/CCM-16644_reporting_permissions branch from a8f5e96 to 302fa06 Compare May 7, 2026 12:29
@gareth-allan gareth-allan changed the title CCM-16644: Update Digital Letters Reporting Rule Permissions CCM-16644: Update Digital Letters Reporting Rule Policy May 11, 2026
@gareth-allan gareth-allan marked this pull request as ready for review May 11, 2026 15:51
@gareth-allan gareth-allan requested a review from a team as a code owner May 11, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant