Skip to content

Conversation

@simonlabarere
Copy link
Contributor

@simonlabarere simonlabarere commented Jul 17, 2025

Description

Added failed reason code to completed comms and completed batch reports.

Context

failedreasoncode is being added to the transaction_history table as part of https://github.com/NHSDigital/comms-mgr/pull/810

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Ian-Hodges
Ian-Hodges previously approved these changes Jul 17, 2025
skaram-nhs
skaram-nhs previously approved these changes Jul 21, 2025
@simonlabarere simonlabarere changed the title CCM-10449: Add failed reason code to completed comms and completed batch reports CCM-11292: Add failed reason code to completed comms and completed batch reports Jul 22, 2025
@simonlabarere simonlabarere force-pushed the feature/CCM-10449_add_failed_reason_codes_to_mesh branch from 64e0bd0 to 957d802 Compare July 22, 2025 08:51
@sonarqubecloud
Copy link

@simonlabarere simonlabarere force-pushed the feature/CCM-10449_add_failed_reason_codes_to_mesh branch from 957d802 to be5a11b Compare October 30, 2025 11:08
@sonarqubecloud
Copy link

@simonlabarere simonlabarere added this pull request to the merge queue Nov 3, 2025
Merged via the queue into main with commit f65ac2f Nov 3, 2025
33 of 34 checks passed
@simonlabarere simonlabarere deleted the feature/CCM-10449_add_failed_reason_codes_to_mesh branch November 3, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants