Skip to content

Conversation

@markpullan
Copy link
Contributor

Description

Change the week-end logic so that Proco invoices reconcile correctly for messages sent on a Saturday and Sunday.

Context

Currently the invoice reconciliation reports messages frm Saturday and Sunday in the wrong invoice week.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@markpullan markpullan requested a review from a team as a code owner September 16, 2025 16:06
@sonarqubecloud
Copy link

@markpullan markpullan added this pull request to the merge queue Sep 17, 2025
Merged via the queue into main with commit 69f9ca2 Sep 17, 2025
30 checks passed
@markpullan markpullan deleted the feature/CCM-12210_Proco_Week_Start branch September 17, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants