Skip to content

CCM-7890 expand backup module#41

Merged
aidenvaines-cgi merged 2 commits intomainfrom
CCM-7890_ExpandBackupModule
Jan 28, 2025
Merged

CCM-7890 expand backup module#41
aidenvaines-cgi merged 2 commits intomainfrom
CCM-7890_ExpandBackupModule

Conversation

@aidenvaines-cgi
Copy link
Copy Markdown
Contributor

Description

  • Fix TFSec pipeline step
  • Rename some variables to make more sense in our context
  • Fix the difference between default and dyanmodb by renming defaulkt as s3 (as it wouldnt work for EFS or EC2 as it is)
  • APply terraform best practices

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@aidenvaines-cgi aidenvaines-cgi added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 35bc1ca Jan 28, 2025
@aidenvaines-cgi aidenvaines-cgi deleted the CCM-7890_ExpandBackupModule branch February 13, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants