Skip to content

CCM-9648 - standardise tfscaffold conventions#68

Merged
aidenvaines-cgi merged 2 commits intomainfrom
feature/CCM-9648-shared-module-module-usage
Apr 11, 2025
Merged

CCM-9648 - standardise tfscaffold conventions#68
aidenvaines-cgi merged 2 commits intomainfrom
feature/CCM-9648-shared-module-module-usage

Conversation

@alexnuttall
Copy link
Copy Markdown
Contributor

Description

  • removes all instances of var.module replacing with a local, to increase clarity around the intention that this should not be overridden.
  • remove var.module from resource names in amp_branch, kms and lambda, to standardise.

Other changes:

  • added local.module (amp) to amplify_branch (module was kms)
  • removed unused csi_global / csi_account / csi locals
  • add missing Name tag in lambda
  • change s3 Name tag from var.name to local.csi_global
  • added var.name to backup-source, currently hardcoded to backup. Added Module = backup to local.default_tags

Questions:

  • Does the change to backup_source make sense?
  • What should local.default_tags.Name be? In this PR have it equal to local.csi_global in s3 and local.csi everywhere else. kms uses a mix of csi and csi_account in resource names/ids

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@alexnuttall alexnuttall changed the title init CCM-9648 - standardise tfscaffold conventions Apr 11, 2025
@aidenvaines-cgi aidenvaines-cgi added this pull request to the merge queue Apr 11, 2025
Merged via the queue into main with commit a053a0a Apr 11, 2025
46 checks passed
@aidenvaines-cgi aidenvaines-cgi deleted the feature/CCM-9648-shared-module-module-usage branch April 11, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants