This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Merged
Conversation
…HSDigital#78) * Added mention of 'message cascades' in routing plan content for 'parallel send' feature mention. * 'or' replaced with 'and' * Message status page created - changes to /using-nhs-notify/mesh to match MESH guidance - sender IDs changed to sender names * Emma 2i requested changes * Added /using-nhs-notify/nhs-app-templates, /using-nhs-notify/email-templates, /using-nhs-notify/text-message-templates and /using-nhs-notify/letter-templates. These are based on the Confluence pages https://nhsd-confluence.digital.nhs.uk/pages/viewpage.action?spaceKey=RIS&title=3.8+Creating+letter+templates onwards, with some minor tweaks to word ordering. Romy has approved this content now. Uploaded the standardised Word doc templates for all 4 channels to /assets/worddocs, and linked to these. Craig in cyber security approved this approach (see ticket for screenshot). Updated /using-nhs-notify/personalisation in line with the Confluence page. The FAQs from onboarding indicated there's a user need to provide the PDS personalisation fields. I also added content on how users provide their own personalisation data, in line with Tan's Confluence page https://nhsd-confluence.digital.nhs.uk/display/RIS/NHS+Notify+%7C+Personalisation+Fields. In /pricing/text-messages, I replaced 'it will count as more than one message' with 'it will be charged as more than one message'. This was prompted by a comment from Romy on the text message template content. I tweaked the content to match the later version of the UI prototype, which we based on findings from user research. * Removed mention of bank holidays from emails and text message delivery times. * Removed unnecessary bullets and headings anchor links in Text message templates. Updated link text for the 4 template pages in the Using NHS Notify parent page - removed 'Creating...' from the start of each link. * Fixed typo in /text-message-templates. Removed 'Creating...' from links on /using-nhs-notify. * Updated names of Word docs to replace spaces with hyphens and make all lower case. Updated downloadable links to follow the approach Jake researched, for example [letter template]({% link assets/worddocs/letter-template-nhs-notify.docx %}) * Removed unnecessary space from line 26 on docs/pages/using-nhs-notify/letter-templates. * Update accept.txt Includes: - Noto - URL - ctrl - pending_enrichment - unnotified - permanent_failure - temporary_failure - technical_failure - precompiled - validation_failed - fullName - namePrefix - clientRef * In /using-nhs-notify/delivery-times#letters, replaced the sentence 'Once your letter has been sent, it can take...' with 'Once you've provided us with recipients' NHS numbers, it can take up to 2 working days for our suppliers to dispatch your letter'. I also added anchor links to the top of the same page, /using-nhs-notify/delivery-times, to make navigation easier. * Added content on what users need to do in order to use recipient contact details that are outside of PDS. * Emma recommendations * Removed address_line_x, clientRef, recipientContactValue and template from the bulleted list of personalisation fields from PDS as these are for internal use only. Restructured the first paragraph under ### Personal Demographics Service (PDS) personalisation fields. This was based off a conversation with Jake and it aims to clarify the link between PDS, NHS numbers and personalisation fields. * In /workspaces/nhs-notify-web-cms-dev/docs/_sass/_nhsnotify.scss I added the line 'flex-wrap: wrap;' in the following code: .nhsuk-header__navigation-list { justify-content: flex-start; flex-wrap: wrap; } This is an interim step to make the main nav list items wrap correctly when the site is viewed on a mobile device. It's not our ultimate solution but it makes the site more mobile responsive and accessible. * Removed mentions of date of birth from failed message status descriptions. Removed date of birth as as an example of a column header in a MESH request. * Added link to NHS Notify MESH documentation in /using-nhs-notify/mesh * Squashed commit of the following: commit 7b904fc Author: Ross Buggins <ross.buggins@nhs.net> Date: Tue Nov 19 17:02:42 2024 +0000 Quick and easy js to auto hide. commit 8aed356 Author: Jake Cosgrove <101206358+jakecosgrove@users.noreply.github.com> Date: Tue Nov 19 16:05:22 2024 +0000 Developer banner and new site banner commit a3d47d2 Author: Jake Cosgrove <101206358+jakecosgrove@users.noreply.github.com> Date: Mon Nov 11 15:47:17 2024 +0000 removed phase banner and underlines from primary nav list items when hovered commit 3a30f41 Author: Jake Cosgrove <101206358+jakecosgrove@users.noreply.github.com> Date: Mon Nov 11 13:50:40 2024 +0000 removed border from phase banner commit fc61be5 Author: Jake Cosgrove <101206358+jakecosgrove@users.noreply.github.com> Date: Fri Nov 8 16:32:05 2024 +0000 Added phase banner component and related sass. Added new template for including pages of content that does not need a side-navigation. commit 45d34e6 Author: Jake Cosgrove <101206358+jakecosgrove@users.noreply.github.com> Date: Tue Nov 5 21:59:47 2024 +0000 two-third column tests * Changed first subheading to a h2 from h3 * Removed the other phase banners from Ross' test * removed phase banner includes due to component not being tested or released by developer * Update personalisation.md * First draft updated guidance * Requested changes * Changes from Alex's review: - corrected typo's - added missing anchor link - included image of example inbox showing sender name and 'from' address * Romy suggested that we use screenshots to show where the sender names appear for NHS App and SMS. This commit includes additional images to support user understanding of sender names and where they sit in context. * This commit includes: - new HTML includes specific for images with captions so they fit 100% of their container - images on pages use new includes - inset text has override style class to reduce margin-top - side nav now disappears when below 768px breakpoint (need to talk to design team about mobile solution) * Added content about sending text message sender names for approval with NCSC. * Use new image-with-text.html includes * Content changes following Emma's 2i * Added 'new' to text message sender names --------- Co-authored-by: Mark R <mark.ramsden5@nhs.net> Co-authored-by: emmagifford <162720670+emmagifford@users.noreply.github.com> Co-authored-by: Ross Buggins <ross.buggins@nhs.net> Co-authored-by: alexcolbeck1 <36191568+alexcolbeck1@users.noreply.github.com>
… into sync-web-cms-dev
bhansell1
approved these changes
Jan 17, 2025
bhansell1
approved these changes
Jan 17, 2025
bhansell1
approved these changes
Jan 17, 2025
emmagifford
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.