Skip to content

Reinstate skipped test and remove print statement#99

Merged
igba1980 merged 1 commit intomasterfrom
enable-smoketest
Feb 22, 2024
Merged

Reinstate skipped test and remove print statement#99
igba1980 merged 1 commit intomasterfrom
enable-smoketest

Conversation

@igba1980
Copy link
Copy Markdown
Contributor

@igba1980 igba1980 commented Feb 22, 2024

Reenabled the previously skipped 'test_status' function in the test_endpoints.py file and renamed it to 'test_status_endpoint'. Removed a redundant print statement from the 'test_ping' function. The updated 'test_status_endpoint' now includes additional assertions to verify the response status.

Summary

  • Routine Change
  • ❗ Breaking Change
  • 🤖 Operational or Infrastructure Change
  • ✨ New Feature
  • ⚠️ Potential issues that might be caused by this change

Add any other relevant notes or explanations here. Remove this line if you have nothing to add.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

Reenabled the previously skipped 'test_status' function in the test_endpoints.py file and renamed it to 'test_status_endpoint'. Removed a redundant print statement from the 'test_ping' function. The updated 'test_status_endpoint' now includes additional assertions to verify the response status.
@igba1980 igba1980 requested a review from adrianparr February 22, 2024 11:12
@igba1980 igba1980 self-assigned this Feb 22, 2024
Copy link
Copy Markdown
Contributor

@adrianparr adrianparr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Copy Markdown
Contributor

@adrianparr adrianparr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Copy Markdown
Contributor

@adrianparr adrianparr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@igba1980 igba1980 merged commit abefb01 into master Feb 22, 2024
@adrianparr adrianparr deleted the enable-smoketest branch March 21, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants