@satnamsinghuk/feature/updates#40
Closed
SatnamSinghUK wants to merge 3 commits intoNHSDigital:masterfrom
Closed
Conversation
Author
|
Following on from #35 I have added this new PR with the direction mentioned on 35. Please could advise based on the changes so far, what would need to happen to accept this as a workable component? Please excuse the unfinished code, as I'm not sure what else needs to be added/removed from the InputWithLink.tsx file at this point :) |
Author
|
@Tomdango @lukepearson @kevinkuszyk Deleting this PR and creating a new one shortly. I realised this does not do what we need it to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for adding in a new InputWithLink component