Chore: [AEA-6270] - seek to reduce Service Search noise thru timeout and keep alive#2424
Merged
tstephen-nhs merged 4 commits intomainfrom Feb 27, 2026
Merged
Chore: [AEA-6270] - seek to reduce Service Search noise thru timeout and keep alive#2424tstephen-nhs merged 4 commits intomainfrom
tstephen-nhs merged 4 commits intomainfrom
Conversation
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-6270 |
tstephen-nhs
commented
Feb 26, 2026
| } | ||
|
|
||
| async searchService(odsCode: string, correlationId: string): Promise<URL | undefined> { | ||
| try { |
Contributor
Author
There was a problem hiding this comment.
This looks more than it is: actually just removes the double error logging in favour of interceptor logging only
|
wildjames
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Summary of changes, albeit a little speculative: