Chore: [AEA-0000] - send old and new key#2447
Merged
tstephen-nhs merged 1 commit intomainfrom Mar 6, 2026
Merged
Conversation
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-0000 |
|
wildjames
approved these changes
Mar 6, 2026
Contributor
wildjames
left a comment
wildjames
left a comment
There was a problem hiding this comment.
Approving this so that RT passes, though we'll have to revert it in the future when SSv3 is fixed
tstephen-nhs
added a commit
that referenced
this pull request
Mar 9, 2026
This reverts commit 005a021.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Investigate regression test failure when calling service search.
Although pre-merge the removal of service search v2 code was passing here it subsequently started failing. The 401 error with message "Access denied due to missing subscription key. Make sure to include subscription key when making requests to an API." suggested that the v3 service is still expecting the old v2 header (subscription-key) and the regression test passing on this PR appears to prove that is the case.