Chore: [AEA-6593] - move to new imports#2601
Merged
anthony-nhs merged 9 commits intomainfrom May 1, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates SAM templates to consume shared infrastructure exports from the newer CDK-based stacks (replacing older account-resources / lambda-resources import names).
Changes:
- Repointed CloudWatch Logs KMS key, Splunk subscription role, and Splunk Firehose delivery stream imports to
account-resources-cdk-uk:*exports. - Updated various IAM managed policy imports (Lambda + Step Functions) to the new export names.
- Updated Slack alerts SNS topic imports for CloudWatch alarms to the new export name.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| SAMtemplates/state_machines/state_machine_resources.yaml | Updates state machine IAM managed policy import to the new CDK export. |
| SAMtemplates/state_machines/main.yaml | Updates parameters passed to the nested state machine resources app (KMS + Splunk imports). |
| SAMtemplates/sandbox_template.yaml | Updates sandbox nested apps and API log group/Splunk subscription imports to the new CDK exports (including truststore bucket import). |
| SAMtemplates/functions/main.yaml | Updates Spine + logging/Splunk-related imports to new CDK/secrets exports. |
| SAMtemplates/functions/lambda_resources.yaml | Updates lambda role managed policy imports (one import value appears malformed). |
| SAMtemplates/apis/api_resources.yaml | Updates API access log group KMS key and Splunk subscription imports to new CDK exports. |
| SAMtemplates/alarms/main.yaml | Updates Slack alert SNS topic imports to the new CDK export. |
| - !ImportValue account-resources:CloudwatchEncryptionKMSPolicyArn | ||
| - !ImportValue account-resources:LambdaDecryptSecretsKMSPolicy | ||
| - !ImportValue account-resources-cdk-uk:IAM:LambdaInsightsLogGroupPolicy:Arn | ||
| - !ImportValue account-resources-cdk-uk::IAM:CloudwatchEncryptionKMSPolicy:Arn |
There was a problem hiding this comment.
!ImportValue account-resources-cdk-uk::IAM:CloudwatchEncryptionKMSPolicy:Arn contains a double colon (cdk-uk::IAM) which will make the ImportValue name invalid and cause the stack to fail to deploy. Update it to the correct export name (likely account-resources-cdk-uk:IAM:CloudwatchEncryptionKMSPolicy:Arn).
Suggested change
| - !ImportValue account-resources-cdk-uk::IAM:CloudwatchEncryptionKMSPolicy:Arn | |
| - !ImportValue account-resources-cdk-uk:IAM:CloudwatchEncryptionKMSPolicy:Arn |
|
tstephen-nhs
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details