Skip to content

Dh apmspii 526 remove content location check from polling loop#57

Merged
DominicH247 merged 8 commits intomasterfrom
dh-APMSPII-526-remove-content-location-check-from-polling-loop
Apr 26, 2021
Merged

Dh apmspii 526 remove content location check from polling loop#57
DominicH247 merged 8 commits intomasterfrom
dh-APMSPII-526-remove-content-location-check-from-polling-loop

Conversation

@DominicH247
Copy link
Copy Markdown
Contributor

Summary

  • Routine Change
  • ❗ Breaking Change
  • 🤖 Operational or Infrastructure Change
  • ✨ New Feature
  • ⚠️ Potential issues that might be caused by this change

Add any other relevant notes or explanations here. Remove this line if you have nothing to add.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

Comment thread docker/async-slowapp/src/handlers.js Outdated
Comment thread docker/async-slowapp/src/handlers.js Outdated
Comment thread docker/async-slowapp/src/handlers.js Outdated
Copy link
Copy Markdown
Contributor

@matt-mercer matt-mercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good to see an explicit test where only the initial content location returns a 'content-location' header too

@matt-mercer matt-mercer force-pushed the dh-APMSPII-526-remove-content-location-check-from-polling-loop branch from 70f15ed to d06f4a4 Compare April 26, 2021 09:38
@DominicH247 DominicH247 merged commit 9ebab1f into master Apr 26, 2021
@DominicH247 DominicH247 deleted the dh-APMSPII-526-remove-content-location-check-from-polling-loop branch April 26, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants