Skip to content

Conversation

@LeoKHoward
Copy link
Contributor

@LeoKHoward LeoKHoward commented Jul 14, 2025

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-5222


📄 Description/Summary of Changes

  • Updated 4 endpoints so now defaults will result in 200 status code

🧪 Developer Testing Carried Out

  • Manual review of changes
  • Validated OAS via Swagger

🧪 Reviewer Testing Required

  • Manual review of changes

✅ Developer Checklist

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX-<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>
  • All acceptance criteria from the Jira ticket are addressed
  • Automated tests (unit/integration/API/infrastructure etc. tests) are added or updated
  • The traceability matrix is updated
    with
    new tests or requirements
  • Assignees and appropriate labels (e.g. terraform, documentation) are added

👀 Reviewer Checklist

  • Changes meet the acceptance criteria of the Jira ticket
  • Code is able to be merged (no conflicts and adheres to coding standards)
  • Sufficient test evidence is provided (manual and/or automated)
  • Infrastructure/operational/build changes are validated (if applicable)

🚀 Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman
collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@github-actions
Copy link

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5222

@LeoKHoward LeoKHoward self-assigned this Jul 14, 2025
@LeoKHoward LeoKHoward added bug Something isn't working documentation Improvements or additions to documentation postman Changes to the postman collection endpoints labels Jul 14, 2025
Copy link
Contributor

@JackPlowman JackPlowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JackPlowman JackPlowman changed the title Bug/npa 5222/fix endpoint default configuration NPA-5222: Fix endpoint default configuration Jul 14, 2025
@LeoKHoward LeoKHoward merged commit 1db24eb into master Jul 14, 2025
17 checks passed
@LeoKHoward LeoKHoward deleted the bug/NPA-5222/fix-endpoint-default-configuration branch July 14, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation endpoints postman Changes to the postman collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants