Skip to content

Task/npa 6618/remove grantee#336

Merged
davesmallnhs merged 10 commits intomasterfrom
task/NPA-6618/remove-grantee
Apr 21, 2026
Merged

Task/npa 6618/remove grantee#336
davesmallnhs merged 10 commits intomasterfrom
task/NPA-6618/remove-grantee

Conversation

@hatwell
Copy link
Copy Markdown
Contributor

@hatwell hatwell commented Apr 16, 2026

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-6618


📄 Description/Summary of Changes

  • Updated OAS Spec to remove any reference to grantee and replace with performer.
  • Updates to examples in OAS for GET Consent and GET Consent/{id} response examples and POST Consent request examples.
  • Update int postman collection.
  • Update sandbox and unit tests

🧪 Developer Testing Carried Out


📋 PR Principles

  • Keep PRs Small and Focused: Ensure the PR addresses a single task or feature to make it easier to review.
  • Multiple PRs for one Ticket: When splitting work into multiple PRs, clearly describe what this PR addresses and outline the remaining work to complete the ticket.
  • Ensure Tests Are Included: Add or update unit, integration, or end-to-end tests to cover the changes made.
  • Follow Coding Standards: Ensure the code adheres to the team's coding guidelines and best practices.
  • Resolve Comments Promptly: If you raise a comment, ensure you follow up and resolve it before approving the PR to maintain clarity and ensure comments are addressed.
  • Foster Learning: PR reviews are an opportunity to share knowledge, provide constructive feedback, and encourage a collaborative environment.

🏷️ Naming Conventions Reminder

Please ensure the following naming conventions are followed:

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX/<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
Successfully started running 1 pipeline(s).

@github-actions
Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6618

@hatwell hatwell force-pushed the task/NPA-6618/remove-grantee branch from b977186 to 0c6e14c Compare April 16, 2026 14:42
@github-actions
Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6618

@github-actions
Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6618

Copy link
Copy Markdown

@davesmallnhs davesmallnhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through #336 and all references look to have been updated correctly. Checked that there is no reference to grantee anywhere in the spec document. This PR looks good to me, approved.

@github-actions
Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6618

@davesmallnhs davesmallnhs merged commit 8b1bf00 into master Apr 21, 2026
17 checks passed
@davesmallnhs davesmallnhs deleted the task/NPA-6618/remove-grantee branch April 21, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants