Exclude generated HTML widget assets from vignettes#86
Closed
Copilot wants to merge 2 commits intoDEV_PhilSprintfrom
Closed
Exclude generated HTML widget assets from vignettes#86Copilot wants to merge 2 commits intoDEV_PhilSprintfrom
Copilot wants to merge 2 commits intoDEV_PhilSprintfrom
Conversation
Co-authored-by: phoman14 <21298645+phoman14@users.noreply.github.com> Agent-Logs-Url: https://github.com/NIDAP-Community/SCWorkflow/sessions/66e12a41-c500-47e4-8f89-a8bbbdf8b4ff
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on Roxygen parameters and descriptions cleanup
Exclude generated HTML widget assets from vignettes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendored/minified third-party web assets (plotly, crosstalk, jquery, htmlwidgets) were being committed under
vignettes/images/Vis_3D_files/as build artifacts from HTML widget rendering, bloating the repo and creating noisy diffs.Changes
.gitignore: Added entries forvignettes/images/Vis_3D.htmlandvignettes/images/Vis_3D_files/to prevent future commits of these artifactsgit rm --cached); files remain on disk and are regenerated during vignette builds✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.