Retry file copy if integrity check has failed#357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
From the SmartScope operations, we've observed that some of the file transfers may fail due to networking issues (sizes do not match). In such cases copy procedure shall be retried.
Implementation
This PR changes integrity check handling in copy_file method.
Previously only one copy attempt was made. If sizes of new and old files do not match - process immediately fails. From our tests - it makes sense to retry this operation as it will eventually succeed. Especially when dealing with the network filesystems.
Now, copy operation will be retried with a 2 second timeout and extended logging for integrity failure events.