Conversation
mattEhall
approved these changes
May 19, 2021
Contributor
mattEhall
left a comment
mattEhall
left a comment
There was a problem hiding this comment.
Thanks. We maybe want to think about adjusting RAFT so it's easy to supply hydrodynamic coefficients as modeling options as well at some point.
Contributor
|
To put it in a some kind of a metaphor, Garrett found the way to get from point A to point B very efficiently, which I did not see. I also got from point A to point B, but I had to go through point C and point D before getting to point B. This is good to merge and I'll only have to change a small thing in the other test scripts, so now it should be compatible with Garrett's WEIS work and the existing RAFT test scripts. Leaving dlsMax and other hydro coeff's as they are for now. |
shousner
added a commit
that referenced
this pull request
Dec 12, 2024
- 'Q' output from CCBlade was in the 'pitch' spot and 'My' output from CCBlade was in the 'roll' spot - these should be flipped - Also updating the default vapor pressure when calculating cavitation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change in wrapper to play nicely with WEIS user options