B/multi re #677
Merged
B/multi re #677
+48
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbarter
reviewed
Nov 24, 2025
wisdem/ccblade/ccblade_component.py
Outdated
| Emax = np.zeros(self.n_span) | ||
| margin2stall = self.options["opt_options"]["constraints"]["blade"]["stall"]["margin"] * 180.0 / np.pi | ||
| Re = np.array(Omega * inputs["r"] * inputs["chord"] * inputs["rho"][0] / inputs["mu"][0]) | ||
| Re = np.array(Omega / 30. * np.pi * inputs["r"] * inputs["chord"] * inputs["rho"][0] / inputs["mu"][0]) |
Member
There was a problem hiding this comment.
Maybe for something like this we should relabel Omega as Omega_rpm where it gets defined 15 rows up? That way it is more obvious to change to rad/sec here?
gbarter
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Prep for another minor release (v4.0.2) to support the use of OSO airfoils, where polars are available at multiple Re. The multi-Re polars were already implemented, but the code had not been tested sufficiently well.
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.
Checklist
Put an
xin the boxes that apply.