Add test for generating api docs#266
Merged
sverhoeven merged 10 commits intomainfrom May 3, 2021
Merged
Conversation
As Windows does not have make
jspaaks
approved these changes
May 3, 2021
jspaaks
left a comment
There was a problem hiding this comment.
my goodness what an absolute disaster windows is. I was not able to run the tests from the template level, but at least I could generate the package and then run pytest and the sphinx build directly.
For the longer term, I think we should consider having two workflows, one to test the template, the other to test the generated package. The latter workflow would then go through the steps of creating a virtual env, install deps, etc, in the workflow file, not as part of the test.
Member
Author
|
Thanks for reviewing. I am just happy it works on CI now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of
make htmlusingsphinx-build ...for better cross-platform compatibility.Also got tests to work on Windows CI (refs #223). It also still works on my laptop:
Refs #213