Merged
Conversation
Introduces a question AddLocalTests to control the existence of the tests folder. If the user selects 'GitHub Actions -> Build' or 'Code analysis (using SonarCloud)' then this option is also selected. Related to #594
567335c to
d55fbb4
Compare
fdiblen
approved these changes
Aug 29, 2024
Member
fdiblen
left a comment
There was a problem hiding this comment.
looks great! Thank you, @abelsiqueira
🦘
Member
Author
|
Thanks for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Type of change
Please delete options that are not relevant.
List of related issues or pull requests**
Refs:
Describe the changes made in this pull request
Introduces a question AddLocalTests to control the existence of the tests folder.
If the user selects 'GitHub Actions -> Build' or 'Code analysis (using SonarCloud)'
then this option is also selected.
Instructions to review the pull request
Possible things to check:
strategy=minimal, thentestsare not presentstrategy=recommended, thentestsare presentstrategy=askand onlyGitHub Actions -> Buildis selected, thentestsare presentstrategy=askand onlyCode analysis (using SonarCloud)is selected, thentestsare presentInstall the requirements
Create a new package using the template
Then run the tests