Skip to content

Make code of conduct email conditional on AddCodeConduct#644

Merged
abelsiqueira merged 1 commit intomainfrom
534-code-of-conduct-email
Aug 29, 2024
Merged

Make code of conduct email conditional on AddCodeConduct#644
abelsiqueira merged 1 commit intomainfrom
534-code-of-conduct-email

Conversation

@abelsiqueira
Copy link
Copy Markdown
Member

Checklist before requesting a review

  • I have read the contribution guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • All user facing changes have been added to CHANGELOG.md

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

List of related issues or pull requests**

Refs:

Describe the changes made in this pull request

Move the code_of_conduct_email question to features_community.yml and only ask it if the user selected AddCodeConduct.

Instructions to review the pull request

Things to try:

  • Use the ask mode and check that the e-mail question is conditional on AddCodeConduct.

Install the requirements

cd $(mktemp -d --tmpdir py-tmpl-XXXXXX)
pip install pipx
pipx install copier

Create a new package using the template

copier copy --vcs-ref <YOUR_BRANCH> https://github.com/nlesc/python-template test_package

Move the code_of_conduct_email question to features_community.yml and
only ask it if the user selected AddCodeConduct.

Related to #534
@abelsiqueira abelsiqueira marked this pull request as ready for review August 29, 2024 15:10
@abelsiqueira abelsiqueira requested a review from fdiblen August 29, 2024 15:11
Copy link
Copy Markdown
Member

@fdiblen fdiblen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you, @abelsiqueira.

🍸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants