[integration-tests] Limit Cascade queries to SOA/XFR#563
Merged
Conversation
tertsdiepraam
approved these changes
Apr 2, 2026
| - name: Query zone | ||
| run: | | ||
| dig @127.0.0.1 -p 4542 example.test AXFR | ||
| dig @127.0.0.1 -p 4542 example.test AXFR > dig-query.log |
Contributor
There was a problem hiding this comment.
Is this for debugging?
Contributor
Author
There was a problem hiding this comment.
It removes the output from act-wrapper's overall stdout, and puts it in a place that it will still get printed on failure. Just a minor improvement.
| SOA_RR=$(dig +short @127.0.0.1 -p 4540 example.test SOA) | ||
| if [[ "${SOA_RR}" != "ns1.example.test. mail.example.test. 1 60 60 3600 5" ]]; then | ||
| echo "::error:: Expected SOA serial '1' but dig reports '${SOA_RR}'" | ||
| dig @127.0.0.1 -p 4540 example.test AXFR |
Contributor
There was a problem hiding this comment.
I wouldn't expect this PR to add more dig commands?
| cat "${{ inputs.cascade-dir }}/cascade-startup.log" >&2 || true | ||
| echo ">>> Logfile cascade.log:" >&2 | ||
| cat "${{ inputs.cascade-dir }}//cascade.log" >&2 || true | ||
| cat "${{ inputs.cascade-dir }}/cascade.log" >&2 || true |
Contributor
There was a problem hiding this comment.
Was this broken or is it just a slight improvement?
Contributor
Author
There was a problem hiding this comment.
Just a slight improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks #552, by limiting queries to Cascade's servers to SOA and XFRs. Also makes some minor changes to other tests.
Cargo.*,crates/,etc/,integration-tests/,src/):actthrough theact-wrapper(as described inTESTING.md)?