Remove zonetree use from zone status#565
Merged
tertsdiepraam merged 1 commit intomainfrom Apr 7, 2026
Merged
Conversation
bal-e
approved these changes
Apr 7, 2026
Contributor
bal-e
left a comment
There was a problem hiding this comment.
Looks good! The way the SOA serials are being extracted is unfortunately not compatible with #552, but @tertsdiepraam and I agreed that I'll make a small follow-up PR to this to fix things. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
Progressinto the API crate so we can construct that directly on the server based on the state machine instead of constructing it on the client side. This meant I had to change some methods to free functions which makes the diff kind of big, but mostly that just gets rid of a level of indentation.Getting the serial of all the zones is kind of hacked in and probably incompatible with #552, but we can probably figure something out there.
I'm keeping this slightly hacky because I'm gonna pick up refining the status next. It will then reflect the state machine more closely.
If you are changing Rust code or integration tests (
Cargo.*,crates/,etc/,integration-tests/,src/):actthrough theact-wrapper(as described inTESTING.md)?If you are adding/deleting man pages:
man_pagesconfig indoc/manual/source/conf.py?Cargo.toml?If you are modifying man pages: