Have sensible default for DNSSEC parameters and document what is miss…#71
Merged
Philip-NLnetLabs merged 6 commits intomainfrom Sep 19, 2025
Merged
Have sensible default for DNSSEC parameters and document what is miss…#71Philip-NLnetLabs merged 6 commits intomainfrom
Philip-NLnetLabs merged 6 commits intomainfrom
Conversation
ximon18
reviewed
Sep 18, 2025
ximon18
reviewed
Sep 18, 2025
| // signing the zone. | ||
| dnskey_inception_offset: 24 * 3600, | ||
| dnskey_signature_lifetime: 14 * 24 * 3600, | ||
| dnskey_remain_time: 14 * 24 * 3600 / 2, |
Member
There was a problem hiding this comment.
Is this trying to say half of dnskey_signature_lifetime? That might be better expressed through a couple of related constants that can't accidentally diverge from one another.
Member
Author
There was a problem hiding this comment.
Yes, I need to move that to constants.
ximon18
reviewed
Sep 18, 2025
|
|
||
| ds_algorithm: Default::default(), | ||
|
|
||
| // It would be best to default to the SOA minimum. However, |
Member
There was a problem hiding this comment.
What's stopping us from giving the SOA MINIMUM to keyset?
Member
Author
There was a problem hiding this comment.
Nothing but complexity. It is possible to take to SOA minimum and send it to keyset as the default-ttl. I'm not sure it is worth the effort.
ximon18
reviewed
Sep 18, 2025
ximon18
approved these changes
Sep 18, 2025
Co-authored-by: Ximon Eighteen <3304436+ximon18@users.noreply.github.com>
Co-authored-by: Ximon Eighteen <3304436+ximon18@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ing.