Introduces apex_remove and apex_extra.#167
Merged
Philip-NLnetLabs merged 2 commits intomainfrom Apr 13, 2026
Merged
Conversation
Philip-NLnetLabs
changed the title
Member
|
You don't say here or on #152 why this change is being made. |
ximon18
reviewed
Apr 9, 2026
Member
Author
|
apex_remove is introduced to avoid hardcoding in signers what records to remove from the unsigned zone. In particular, a key manager with multi-signer support may take control over NS. apex_extra is introduced to avoid having multiple fields that all need to be added to the apex. With the question what has to happen when the key manager need to deal with new types. For example CSYNC. |
ximon18
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apex_remove and apex_extra will replace dnskey_rrset, cds_rrset, and ns_rrset. Fixes #152