Implement support for the RP record type#620
Merged
mozzieongit merged 6 commits intomainfrom Mar 19, 2026
Merged
Conversation
Member
|
Related RFC: https://www.rfc-editor.org/rfc/rfc1183#section-2 |
Member
|
Should this PR also update |
ximon18
reviewed
Mar 18, 2026
ximon18
reviewed
Mar 18, 2026
ximon18
reviewed
Mar 18, 2026
ximon18
reviewed
Mar 18, 2026
ximon18
reviewed
Mar 18, 2026
ximon18
reviewed
Mar 18, 2026
ximon18
reviewed
Mar 18, 2026
ximon18
reviewed
Mar 18, 2026
ximon18
reviewed
Mar 18, 2026
ximon18
reviewed
Mar 18, 2026
ximon18
reviewed
Mar 18, 2026
ximon18
approved these changes
Mar 18, 2026
Member
ximon18
left a comment
There was a problem hiding this comment.
My comments are mainly nits, nothing blocking.
Co-authored-by: Ximon Eighteen <3304436+ximon18@users.noreply.github.com>
Member
Author
@bal-e is on it in a different PR |
1 task
partim
added a commit
that referenced
this pull request
Apr 23, 2026
Breaking changes * Added new `LimitExceeded` variant to `MessageBuilder`'s `PushError`. ([#349]) * Changed the `Resolver` and `SearchNames` traits of the stub resolver to use lifetimes for associated types. This makes it easier to keep the stub resolver behind an arc or other smart pointer. ([#596]) New * Added `rdata::dnssec::Timestamp::to_system_time` to help sorting timestamps. ([#548]) * Added support for the `TLSA`, `OPENPGPKEY`, `SSHFP`, and `IPSECKEY` record types and added presentation format support for the `SVCB`/`HTTPS` record types. ([#569]) * Added support for the `CAA` record type. ([#434] by [@weilence]) * Added `FreezeBuilder` to the message compressors. ([#601] by [@rossmacarthur]) * Added support for the `RP` record type. ([#620]) * Added a position counter to the zonefile parser, available via `Zonefile::current_offset`. ([#642]) Improvements * Excluded `moka` dependency from the `resolv` feature, reducing the number of dependencies and compile time significantly. ([#575] by [@WhyNotHugo]) * Made various methods in `RelativeName` into const fns. ([#576] by [@WhyNotHugo]) Bug fixes * When parsing a Bind-style public key file, allow an optional TTL field. ([#593]) * `XfrMiddlewareService` should always support at least one concurrent XFR. ([#599]) * Fixed generating an ED448 keypair. ([#608]) Unstable features * `unstable-crypto-sign` * Added support for RSA/SHA-512 to openssl signer. ([#550]) * `generate` now takes `&GenerateParams`. This breaks existing uses of `generate` ([#608]) * `unstable-server-transport` * Return an error response when a `Service` returns a `ServiceError`. ([#390]) * Implemented `std::error::Error` for `ServiceError`. ([#570] by [@rossmacarthur]) * Be more lenient when timing out connections while they are in a transaction. ([#399]) * Removed defaults for type arguments to prevent intermediate types that impl the trait from not allowing the defaults to be overridden. ([#484]) * Added commonly required bounds to the `Service` trait rather than leaving them to the impl. ([#484]) * Removed unnecessary `?Sized` bound on `impl Service for U where U: Deref`. ([#484]) * `unstable-sign` * keyset improvements ([#551]) * Store the algorithm and key tag of a key to be able to reject duplicate key tags and accidental algorithm rolls. * Store whether a key is considered available for a key roll. Rolls with new keys that are not available are rejected. * Added two alternative key rolls for KSK and ZSK key rolls. * Added an algorithm roll. * Added more operations on UnixTime. * Added more actions * Allow loading public keys only. ([#594]) * Added support for decoupled keys. ([#594]) * `RecordsIter::new` has been replaced with `RecordsIter::new_from_owned`. There is a new `RecordsIter::new_from_refs` that takes a `&[&Record]]`. This breaks existing uses of `RecordsIter? and related types. ([#614]) * `unstable-xfr` * Various fixes and improvements. ([#507]) Other changes * Dependency upgrades: * [hashbrown] to 0.17, ([#633]) * [heapless] to 0.9, ([#634]) * [octseq] to 0.6, ([#634]) * [rand] to 0.10. ([#631])
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I referenced the Soa file and implemented all the functions it had.
Fixes: NLnetLabs/cascade#421