Skip to content

Implement support for the RP record type#620

Merged
mozzieongit merged 6 commits intomainfrom
rp-rrtype
Mar 19, 2026
Merged

Implement support for the RP record type#620
mozzieongit merged 6 commits intomainfrom
rp-rrtype

Conversation

@mozzieongit
Copy link
Copy Markdown
Member

I referenced the Soa file and implemented all the functions it had.

Fixes: NLnetLabs/cascade#421

@mozzieongit mozzieongit requested a review from partim March 10, 2026 13:44
@mozzieongit mozzieongit self-assigned this Mar 10, 2026
@ximon18
Copy link
Copy Markdown
Member

ximon18 commented Mar 18, 2026

@ximon18
Copy link
Copy Markdown
Member

ximon18 commented Mar 18, 2026

Should this PR also update src/new ?

Comment thread src/rdata/rp.rs
Comment thread src/rdata/rp.rs
Comment thread src/rdata/rp.rs Outdated
Comment thread src/rdata/rp.rs Outdated
Comment thread src/rdata/rp.rs
Comment thread src/rdata/rp.rs Outdated
Comment thread src/rdata/rp.rs
Comment thread src/rdata/rp.rs Outdated
Comment thread src/rdata/rp.rs
Comment thread src/rdata/rp.rs
Comment thread src/rdata/rp.rs Outdated
Copy link
Copy Markdown
Member

@ximon18 ximon18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are mainly nits, nothing blocking.

@mozzieongit
Copy link
Copy Markdown
Member Author

Should this PR also update src/new ?

@bal-e is on it in a different PR

@mozzieongit mozzieongit merged commit 966ffaa into main Mar 19, 2026
15 checks passed
@mozzieongit mozzieongit deleted the rp-rrtype branch March 19, 2026 14:08
partim added a commit that referenced this pull request Apr 23, 2026
Breaking changes

* Added new `LimitExceeded` variant to `MessageBuilder`'s `PushError`.
  ([#349])
* Changed the `Resolver` and `SearchNames` traits of the stub resolver to
  use lifetimes for associated types. This makes it easier to keep the stub
  resolver behind an arc or other smart pointer. ([#596])

New

* Added `rdata::dnssec::Timestamp::to_system_time` to help sorting timestamps.
  ([#548])
* Added support for the `TLSA`, `OPENPGPKEY`, `SSHFP`, and `IPSECKEY`
  record types and added presentation format support for the `SVCB`/`HTTPS`
  record types. ([#569])
* Added support for the `CAA` record type. ([#434] by [@weilence])
* Added `FreezeBuilder` to the message compressors. ([#601] by
  [@rossmacarthur])
* Added support for the `RP` record type. ([#620])
* Added a position counter to the zonefile parser, available via
  `Zonefile::current_offset`. ([#642])

Improvements

* Excluded `moka` dependency from the `resolv` feature, reducing the number
  of dependencies and compile time significantly. ([#575] by [@WhyNotHugo])
* Made various methods in `RelativeName` into const fns. ([#576] by
  [@WhyNotHugo])

Bug fixes

* When parsing a Bind-style public key file, allow an optional TTL field.
  ([#593])
* `XfrMiddlewareService` should always support at least one concurrent XFR.
  ([#599])
* Fixed generating an ED448 keypair. ([#608])

Unstable features

* `unstable-crypto-sign`
  * Added support for RSA/SHA-512 to openssl signer. ([#550])
  * `generate` now takes `&GenerateParams`. This breaks existing uses of
    `generate` ([#608])
* `unstable-server-transport`
  * Return an error response when a `Service` returns a `ServiceError`.
    ([#390])
  * Implemented `std::error::Error` for `ServiceError`. ([#570] by
    [@rossmacarthur])
  * Be more lenient when timing out connections while they are in a
    transaction. ([#399])
  * Removed defaults for type arguments to prevent intermediate types that
    impl the trait from not allowing the defaults to be overridden.
    ([#484])
  * Added commonly required bounds to the `Service` trait rather than
    leaving them to the impl. ([#484])
  * Removed unnecessary `?Sized` bound on `impl Service for U where U: Deref`.
    ([#484])
* `unstable-sign`
   * keyset improvements ([#551])
     * Store the algorithm and key tag of a key to be able to reject duplicate
       key tags and accidental algorithm rolls.
     * Store whether a key is considered available for a key roll. Rolls with
       new keys that are not available are rejected.
     * Added two alternative key rolls for KSK and ZSK key rolls.
     * Added an algorithm roll.
     * Added more operations on UnixTime.
     * Added more actions
     * Allow loading public keys only. ([#594])
     * Added support for decoupled keys. ([#594])
   * `RecordsIter::new` has been replaced with `RecordsIter::new_from_owned`.
     There is a new `RecordsIter::new_from_refs` that takes a `&[&Record]]`.
     This breaks existing uses of `RecordsIter? and related types. ([#614])
* `unstable-xfr`
  * Various fixes and improvements. ([#507])

Other changes

* Dependency upgrades:
  * [hashbrown] to 0.17, ([#633])
  * [heapless] to 0.9, ([#634])
  * [octseq] to 0.6, ([#634])
  * [rand] to 0.10. ([#631])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cascade doesn't support RP resource records

2 participants