Introduce a new compiler pass: MIR #182
Conversation
tertsdiepraam
changed the title
|
Alright, this is ready for review. Not saying it's great, but I need a second pair of eyes on it now. All the tests pass at least. |
|
I'll list out some notable changes I made along the way:
|
bal-e
left a comment
bal-e
left a comment
There was a problem hiding this comment.
Amazingly well done, @tertsdiepraam! This is a major change and it's going to make it way easier to develop Roto further. I've left some minor notes, but they can all be addressed later.
| /// Integer addition | ||
| Add { | ||
| to: Var, | ||
| left: Operand, | ||
| right: Operand, | ||
| }, | ||
|
|
||
| /// Integer subtraction | ||
| Sub { | ||
| to: Var, | ||
| left: Operand, | ||
| right: Operand, | ||
| }, |
There was a problem hiding this comment.
I don't see FAdd or FSub... do these instructions cover floating-points too?
There was a problem hiding this comment.
Currently the codegen step makes that distinction, div is different because it needs info on signedness for integers. I should refactor this to a binop instruction or something. But that's for later.
src/lir/print.rs
Outdated
| label_store: printer.label_store, | ||
| }; | ||
|
|
||
| s.push_str(&format!( |
| @@ -0,0 +1,99 @@ | |||
| //! Dead code elimination on the MIR | |||
There was a problem hiding this comment.
This only eliminates dead branches, not dead instructions within used blocks, right? That'll be a lot harder to do, but also a lot more interesting.
There was a problem hiding this comment.
Yeah, that's true
src/mir/mod.rs
Outdated
| @@ -0,0 +1,156 @@ | |||
| //! Mid-level intermediate representation (MIR) | |||
| //! | |||
| //! This is the first intermediate representation. It is baed on basic blocks | |||
2 participants
No description provided.