Rename Optional to Option
#216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tertsdiepraam
force-pushed
the
optional-to-option
branch
3 times, most recently
from
3b79224 to
20c7218
Compare
tertsdiepraam
force-pushed
the
optional-to-option
branch
from
20c7218 to
c92102b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally introduced
Optionalwith that name because I thought that it wouldn't be possible for users to passOption<T>to Roto. The nameOptionalwould then make it easier to distinguish Rust'sOption<T>from Roto'sOptional<T>. However, with thetransformsystem in theReflecttrait, it is now just possible to pass aOption<T>to Roto and the transformation to the proper Roto type will happen automatically. Therefore, I don't want to bother users with the distinction anymore.