Fix miscompilations around equality #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tertsdiepraam
force-pushed
the
prefix-eq
branch
3 times, most recently
from
a198e95 to
1168668
Compare
tertsdiepraam
force-pushed
the
prefix-eq
branch
from
1168668 to
9a71fa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot assume (anymore) that enums, records and prefixes can be compared with
memcmp. Doing this would cause Roto to silently do the wrong thing. This PR makes the following changes:==and!=. Enums and records are no longer allowed. Float var types were missing so those are added.Prefixto ensure that the implementation is (and will stay) correct. This also means we don't use thememcmplibcall anymore, which is a nice bonus with regards to Fix musl build of Roto #286Prefix.Prefix.This should go into 0.8.1 as it fixes some serious issues. It is a breaking change, but only for cases where Roto would previously miscompile.