Skip to content

Conversation

@YodaDaCoda
Copy link
Contributor

  • Pipe output instead of console.error
    • console.error adds extra newlines and possibly does other formatting which we don't want
  • By using child_process.spawn instead of child_process.exec, we don't have to do so much manual handling of args.
    • This was causing me problems trying to execute PMD as flags were getting sent wrapped in quotes.

@NLueg
Copy link
Owner

NLueg commented Apr 9, 2021

Thank you very much for your PR and especially the nice refactoring you made!

@NLueg NLueg merged commit 2792773 into NLueg:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants