Skip to content

Conversation

@jaygiang
Copy link
Collaborator

  • Remove PWA lesson(move to a later lesson)
  • Install Docusaurus Canary release to allow count start for showLineNumbers in code snipped
  • Add showLineNumber=start-number to lesson-1.mdx
Screenshot 2025-05-19 at 10 50 29 PM

@jaygiang jaygiang requested review from theangchen and thgaskell May 20, 2025 05:51
Copy link
Collaborator

@theangchen theangchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a newbie coming to the docs, I think we need to keep the portion of "Getting Started" that shows them how to get the app up and running on localhost before we dive into adding button functionality in code. So they know where to look to see their changes.

@jaygiang jaygiang requested a review from theangchen May 21, 2025 06:19
Copy link
Collaborator

@theangchen theangchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked through Lesson 1 ✅ LGTM

@jaygiang
Copy link
Collaborator Author

@theangchen removed the diffs from GridContainer snippet and added showLineNumber to the import snippet. Please review.

@jaygiang jaygiang requested a review from theangchen May 29, 2025 21:44
@theangchen theangchen added the Learning Mod Learning module on docs label May 29, 2025
@theangchen theangchen moved this to Needs Review in RADFish Project Board May 29, 2025
Copy link
Collaborator

@theangchen theangchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Learning Mod Learning module on docs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants