-
Notifications
You must be signed in to change notification settings - Fork 1
Lesson 1 cleanup #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lesson 1 cleanup #186
Conversation
theangchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a newbie coming to the docs, I think we need to keep the portion of "Getting Started" that shows them how to get the app up and running on localhost before we dive into adding button functionality in code. So they know where to look to see their changes.
theangchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked through Lesson 1 ✅ LGTM
|
@theangchen removed the diffs from |
theangchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM
Lesson 2 cleanup
showLineNumbersin code snippedshowLineNumber=start-numbertolesson-1.mdx