Skip to content

CLI: Improve convolution function detection #386

@felixhekhorn

Description

@felixhekhorn

in this line:

let (name, typ) = fun.split_once('+').unwrap_or((fun, ""));

the split should happen once from the right, i.e. what Python calls rsplit('+', 1) this ensures that if the convolution function name does contain an explicit +, for whatever stupid reason, it can still be used by adding an explicit + to the end. The alternative is to allow to escape that +, which is more complicated however ...

cc @samiyrj

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions