fail if there is a mismatch in the number of iterations#245
Merged
scarlehoff merged 4 commits intomainfrom Apr 10, 2026
Merged
Conversation
Member
Author
|
Funny, the bechmarks are using inconsistent iterations :) |
Contributor
it just proves the point 🙈 can you please fix the files on the server? PS: @Radonirinaunimi #215 has an explicit item in the todo list 🙈 |
Member
Indeed - which is supposed to be ultimate benchmark/regression tests and is operational. |
felixhekhorn
changed the title
Member
Author
|
It's a bit more complicated than that, it is also using old datasets. The yamldb. Truncated. It was never updated to 4.1. Let me fix the benchmark so it passes and later we redo the regression test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.