fre.cmor: a CMIP7 example, toward general CMIP7 compatibility #715
Open
fre.cmor: a CMIP7 example, toward general CMIP7 compatibility #715
fre.cmor: a CMIP7 example, toward general CMIP7 compatibility #715Conversation
This was
linked to
issues
Feb 2, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #715 +/- ##
==========================================
- Coverage 82.76% 82.65% -0.11%
==========================================
Files 68 68
Lines 4525 4578 +53
==========================================
+ Hits 3745 3784 +39
- Misses 780 794 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ilaflott
force-pushed
the
use-cmip7-tablesv2
branch
from
85e51f9 to
e0f6daa
Compare
ilaflott
force-pushed
the
use-cmip7-tablesv2
branch
from
e0f6daa to
135cd09
Compare
…on. good point to stop and see if any other part budged.
Member
Author
…squash complaints about the user input configuration json
Member
Author
…r input configuration until testing pipeline success.
…native ocean grid case
ilaflott
changed the title
fre cmor routinesfre cmor, toward general CMIP7 compatibility
Member
Author
8 tasks
Contributor
Member
Author
8 tasks
Contributor
Member
Author
singhd789
reviewed
Feb 5, 2026
| ''' | ||
| is_ci = os.environ.get("GITHUB_WORKSPACE") is not None | ||
| if is_ci: | ||
| #doesn't run happily in CI and not needed |
Collaborator
There was a problem hiding this comment.
Should there be a test failure if is_ci is True? (since you commented it doesn't run happily in CI) Or would that never really happen?
Member
Author
There was a problem hiding this comment.
if is_ci throws a failure, then the pipeline fails! we wouldn't want that.
there should be added lines below this: if not is_ci: <do_stuff>. does nothing otherwise and passes without a need to explicitly assert True
Member
Author
There was a problem hiding this comment.
ilaflott
commented
Feb 5, 2026
Comment on lines
-288
to
+299
| if is_ci: | ||
| #doesn't run happily in CI and not needed | ||
| assert True | ||
| else: | ||
| git_cmd = f"git restore {EXP_CONFIG}" | ||
| restore = subprocess.run(git_cmd, | ||
| shell=True, | ||
| check=False) | ||
| check_cmd = f"git status | grep {EXP_CONFIG}" | ||
| check = subprocess.run(check_cmd, | ||
| shell = True, check = False) | ||
| #first command completed, second found no file in git status | ||
| assert all([restore.returncode == 0, check.returncode == 1]) | ||
| if not is_ci: | ||
| git_cmd = f"git restore {EXP_CONFIG}" | ||
| restore = subprocess.run(git_cmd, | ||
| shell=True, | ||
| check=False) | ||
| check_cmd = f"git status | grep {EXP_CONFIG}" | ||
| check = subprocess.run(check_cmd, |
…ve (?) sections. add the case2 variantion on cli call for cmip7 scenario
…ack, tweak some comments and organization.
ilaflott
changed the title
fre cmor, toward general CMIP7 compatibility fre.cmor: a CMIP7 example, toward general CMIP7 compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
cmip7-cmor-tablesas agitsubmodule, right next tocmip6-cmor-tablesfre/tests/test_fre_cmor_cli.pyxfailfrom tests that now pass (in an intended manner)cmor_mixeris still backwards-compatible for CMIP6 cases as of this PR. for CMIP7 cases:GLOBAL_MIP_ERAtocmor_mixerto track whichmip_eraa cmorization call is formip_era. if CMIP6, function as previous versions didIssue ticket number and link (if applicable)
#641, #639
Checklist before requesting a review